Fix missing externalPort in web-ingress.yaml. #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is to fix Issue: #148 |
@xB-2048 / @KoppulaRajender please review and approve |
xB-2048
approved these changes
Dec 17, 2020
There was a problem hiding this comment.
@kenmccann Thanks for the PR.
@rshmiel The change looks good to me and the PR can be merged.
KoppulaRajender
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
web-ingress.yaml references "externalPort" in values.yaml which does not exist. Since we are hard coding an http backend, we should point to the aqua-web port using http only.