issue #50: exposes OutputResults functionality

[robertojrojas]

Clients can re-use the util.OutputResults function.
Here is an example:

outcfg := &util.OutputConfig{
  OutputFile:        outputFile,
  NoRemediations:    noRemediations,
  IncludeTestOutput: includeTestOutput,
}
err = util.OutputResults(controls, summary, outcfg)
...

[codecov-io]

Codecov Report

Merging #51 into master will increase coverage by 4.55%.
The diff coverage is 63.63%.

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
+ Coverage   58.38%   62.93%   +4.55%     
==========================================
  Files           5        5              
  Lines         507      518      +11     
==========================================
+ Hits          296      326      +30     
+ Misses        186      156      -30     
- Partials       25       36      +11

Impacted Files	Coverage Δ
util/util.go	41.66% <63.63%> (+21%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de62def...581aa0f. Read the comment docs.

[lizrice]

This is great as far as it goes, but I have a couple of suggestions for even better :-)

[lizrice]

This would be fine to start with, but I think it would be better to have an Outputter interface because there might be more options in future. In fact kube-bench already has regular output, JSON output, and an option to write output to a postgres database. Wdyt?

[robertojrojas]

hmm... that's a great idea. I can definitely see the need to send the output to NoSQL dbs and the interface would make it easier to add different implementations. One thing I'm of is how to strike a balance between bench-common providing default Outputters while allowing *-bench specific extensions.

[lizrice]

Bit of an optional extra but it would be nice to test that the json output is as expected

[robertojrojas]

Thinking twice about this, the test is highlighting the problem of a filename being passed in instead of io.Writer

[lizrice]

This is now superceded by #52