Fix condition key name of Amazon SNS topic policies #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi @AkhtarAmir, could you please review this PR? |
AkhtarAmir
suggested changes
Aug 25, 2021
plugins/aws/sns/topicPolicies.js
Outdated
| @@ -86,7 +86,7 @@ module.exports = { | |||
| var conditionExists = (statement.Condition ? true : false); | |||
| // Is it a string condition (StringEquals)? Is the SourceOwner open to everyone? | |||
| var conditionString = ((statement.Condition && statement.Condition.StringEquals && | |||
| (statement.Condition.StringEquals['AWS:SourceOwner'] || !statement.Condition.StringEquals['AWS:SourceOwner'] == '*')) ? true : false); | |||
| (statement.Condition.StringEquals['aws:SourceOwner'] || !statement.Condition.StringEquals['aws:SourceOwner'] == '*')) ? true : false); | |||
There was a problem hiding this comment.
Can you make it case insensitive?
|
@AkhtarAmir also, I found a bug and fixed dd01a28. |
AkhtarAmir
approved these changes
Aug 26, 2021
|
I'm working on fixing errors 🏃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix condition key case from
AWS:SourceOwnertoaws:SourceOwner.According to the document, there should be start with
aws:instead ofAWS:.https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_policies_condition-keys.html
https://docs.aws.amazon.com/sns/latest/dg/sns-access-policy-use-cases.html