Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate allowed actions #1488

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Conversation

nikpivkin
Copy link
Collaborator

@nikpivkin nikpivkin commented Oct 30, 2023

Added a command to generate a file with actions that do not support resource level permissions. This will allow periodic synchronisation with AWS. There are about 5135 such actions now (vs 3600 in the main branch).

Related issues

@simar7
Copy link
Member

simar7 commented Oct 30, 2023

How often does this list change? While the logic to auto generate is nice, I'm afraid it adds unnecessary complexity and is prone to breakage, if AWS decides to change their page which is likely as it isn't a contract/API.

@nikpivkin
Copy link
Collaborator Author

@simar7 I found a repository with documentation, but it's already archived. I don't know how often this list changes, but so far more than 1k actions have been added (or changed) compared to the main branch. Is there any idea how we can update the actions?

@nikpivkin
Copy link
Collaborator Author

This repository contains a list of actions and it is updated frequently.

@simar7
Copy link
Member

simar7 commented Nov 15, 2023

This repository contains a list of actions and it is updated frequently.

Feels a little better than scraping, maybe we can go with this for the meantime since we don't have any better alternatives.

@nikpivkin
Copy link
Collaborator Author

@simar7 I gave the example of this repository to show that changes to AWS services happen quite often. But this repository is not suitable for us because it only contains a list of actions, and we also need information about the resources required for each action.

@simar7
Copy link
Member

simar7 commented Dec 11, 2023

@simar7 I gave the example of this repository to show that changes to AWS services happen quite often. But this repository is not suitable for us because it only contains a list of actions, and we also need information about the resources required for each action.

I guess it's fine as it is a self contained piece of code with no better alternatives at the moment.

@nikpivkin nikpivkin force-pushed the allowed-actions branch 3 times, most recently from 8e58c12 to 28e03f8 Compare December 12, 2023 09:22
@nikpivkin
Copy link
Collaborator Author

nikpivkin commented Dec 12, 2023

@simar7 Test run of the workflow nikpivkin@7c0ae85

@simar7
Copy link
Member

simar7 commented Jan 10, 2024

@simar7 Test run of the workflow nikpivkin@7c0ae85

lgtm, should we merge this PR?

@nikpivkin nikpivkin marked this pull request as ready for review January 10, 2024 06:38
@simar7 simar7 merged commit f53aebc into aquasecurity:master Jan 12, 2024
5 checks passed
@nikpivkin nikpivkin deleted the allowed-actions branch January 12, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants