This repository has been archived by the owner on Jun 21, 2022. It is now read-only.
add azure token auth #371
Merged
add azure token auth #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
cgroschupp
force-pushed
the
add-azure-token-auth
branch
from
59da605
to
a2d832a
Compare
|
Thanks for the contribution! We prefer depending on well-maintained libraries. Can we implement it without chrismellard/docker-credential-acr-env? |
cgroschupp
force-pushed
the
add-azure-token-auth
branch
from
3e4f4da
to
5aecf45
Compare
cgroschupp
force-pushed
the
add-azure-token-auth
branch
from
5aecf45
to
7670dd9
Compare
|
@knqyf263 ok i removed the docker-credential-acr-env module. i will add tests with "net/http/httptest". |
|
Thanks for the update. |
cgroschupp
force-pushed
the
add-azure-token-auth
branch
from
13f39cb
to
3b4530a
Compare
|
Test are added. |
knqyf263
approved these changes
Jan 19, 2022
|
Merge this PR after updating Go to 1.17. |
|
Thanks! |
|
@knqyf263 thank you for your support. |
|
Note that this is not effective in Trivy until Trivy updates the version of fanal. If you want to support this capability, it would be appreciated if you open a pull request in Trivy. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.