-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pom): skipping missing modules #210
Conversation
ee5cb6d
to
efdd7f7
Compare
@knqyf263 could you review this please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @liorj-orca
Thanks for your work!
I added 1 comment.
Can you also add test for this case?
Regards, Dmitriy
efdd7f7
to
b81fc5c
Compare
Hi @DmitriyLewen, I changed the log level to debug. |
Hello @liorj-orca
Good solution! PR currently looks good to me. |
@DmitriyLewen what else needs to be done so we could merge this and update trivy go.mod so the change would be populated? |
Hello @liorj-orca |
Hello @liorj-orca Can you open new PR in Trivy and update |
Following the issue described at aquasecurity/trivy#3747 where for the case where you run :
trivy fs pom.xml
with the following pom.xml:
you get zero results due to a parser error of one of the dependencies in the pom.
The following PR suggests skipping those missing modules.