feat(jar): add version for SearchByArtifactID function #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitriyLewen
commented
Nov 22, 2023
| @@ -153,7 +153,7 @@ func (s Sonatype) SearchBySHA1(sha1 string) (jar.Properties, error) { | |||
| }, nil | |||
| } | |||
|
|
|||
| func (s Sonatype) SearchByArtifactID(artifactID string) (string, error) { | |||
| func (s Sonatype) SearchByArtifactID(artifactID, _ string) (string, error) { | |||
There was a problem hiding this comment.
In Trivy we use trivy-java-db.
Tell me if you want to update the sonatype logic as well.
8 tasks
knqyf263
approved these changes
Nov 28, 2023
DmitriyLewen
deleted the
feat-jar/add-version-for-search-by-artifactid
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add version to
SearchByArtifactIDfunction (for Client interface) so that you can get the GroupId with only the required version.See aquasecurity/trivy/issues/5627