Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

false positive on RotateKubeletServerCertificate test in openshift 3.11 #304

Closed
vsevel opened this issue Jun 6, 2019 · 1 comment · Fixed by #309
Closed

false positive on RotateKubeletServerCertificate test in openshift 3.11 #304

vsevel opened this issue Jun 6, 2019 · 1 comment · Fixed by #309

Comments

@vsevel
Copy link

vsevel commented Jun 6, 2019

Hello,

I am running kube-bench on the a compute node in openshift 3.11
my node-config.yaml contains:

feature-gates:
  - RotateKubeletClientCertificate=true,RotateKubeletServerCertificate=true

I run:
docker run --rm --pid=host -v /etc:/etc:ro -v /var:/var:ro -t aquasec/kube-bench:latest node --version ocp-3.10

and I get:

[PASS] 7.14 Verify that the RotateKubeletClientCertificate argument is set to true
[FAIL] 7.15 Verify that the RotateKubeletServerCertificate argument is set to true

If I change the client certificate value to false:

  feature-gates:
  - RotateKubeletClientCertificate=false,RotateKubeletServerCertificate=true

then I get:

[FAIL] 7.14 Verify that the RotateKubeletClientCertificate argument is set to true
[FAIL] 7.15 Verify that the RotateKubeletServerCertificate argument is set to true

which is appropriate for the client but not for the server.

Expectation: 7.15 should not fail when we have:

  feature-gates:
  - RotateKubeletClientCertificate=true,RotateKubeletServerCertificate=true
@simar7
Copy link
Member

simar7 commented Jun 10, 2019

I'd like to tackle this if it's still up for grabs.

cc/ @lizrice

simar7 added a commit to simar7/kube-bench that referenced this issue Jun 10, 2019
This improves the TestControls_RunChecks() test by making
more comprehensive assertions on a more fully fledged input yaml

Fixes: aquasecurity#304

Signed-off-by: Simarpreet Singh <simar@linux.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants