Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support run tests which have complex shell commands #604

Closed
mozillazg opened this issue Apr 14, 2020 · 0 comments · Fixed by #610
Closed

Support run tests which have complex shell commands #604

mozillazg opened this issue Apr 14, 2020 · 0 comments · Fixed by #610

Comments

@mozillazg
Copy link
Collaborator

mozillazg commented Apr 14, 2020

There are some scored item have been marked manual because of it need complex shell commands to run test but kube-bench don't support it. Change to support run complex shell commands can avoid this issue and fix issues like #598 too.

kube-bench run tests via parse test command as a simple single line command then run it, this way don't support complex shell commands.

func textToCommand(s string) []*exec.Cmd {

What about change to run the test command just as run a shell script, this way can support complex commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant