-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding kubelet config.yaml path which is used in kubeadm for centos a… #208
Conversation
Oh... I think you have uncovered something more significant!
If the above is correct, I think we are currently using $kubeletconf to represent both the parameters file which should be I'd suggest
Wdyt? I would appreciate someone else checking my working here @OrlinVasilev @ttousai |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lizrice your deductions are completely correct, we will need a new parameter for the correct behaviour.
This will require change in the Go code to pick it up. I will take care of it.
@lizrice completely agree I'll be more than happy to help out with that :) |
This fix applies to only checks for kubernetes versions 1.8 and 1.11. See #208.
@OrlinVasilev we think this is now sorted out with #228 - does this work for you? |
@lizrice you looks great thanks |
…nd ubuntu