Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use COPY instead of ADD in Dockerfile #502

Merged
merged 2 commits into from Nov 27, 2019

Conversation

gy741
Copy link
Contributor

@gy741 gy741 commented Oct 29, 2019

Hello,

The use of COPY is preferred over ADD when additional functionalities of ADD are not being used (like spraying the contents of a tar in a folder).

Ref: https://docs.docker.com/engine/articles/dockerfile_best-practices/#add-or-copy

Thanks.

@codecov
Copy link

codecov bot commented Oct 29, 2019

Codecov Report

Merging #502 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #502   +/-   ##
======================================
  Coverage    65.8%   65.8%           
======================================
  Files          11      11           
  Lines        1000    1000           
======================================
  Hits          658     658           
  Misses        305     305           
  Partials       37      37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c6d4de...ae277ff. Read the comment docs.

Copy link
Contributor

@robertojrojas robertojrojas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertojrojas robertojrojas merged commit 230d286 into aquasecurity:master Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants