Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #439: Adds integration testing using KIND #520

Merged
merged 8 commits into from Nov 16, 2019

Conversation

robertojrojas
Copy link
Contributor

Fixes issue #439:

Adds integration testing using KIND

@codecov
Copy link

codecov bot commented Nov 14, 2019

Codecov Report

Merging #520 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #520   +/-   ##
======================================
  Coverage    65.8%   65.8%           
======================================
  Files          11      11           
  Lines        1000    1000           
======================================
  Hits          658     658           
  Misses        305     305           
  Partials       37      37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ffd382...9f1a6d7. Read the comment docs.

@robertojrojas robertojrojas changed the title [WIP] Fixes issue #439: Adds integration testing using KIND Fixes issue #439: Adds integration testing using KIND Nov 15, 2019
@lizrice lizrice requested review from simar7 and removed request for lizrice November 15, 2019 20:36
integration/integration.go Outdated Show resolved Hide resolved
integration/integration.go Outdated Show resolved Hide resolved
integration/integration.go Outdated Show resolved Hide resolved
Copy link
Member

@simar7 simar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat! lgtm, ran it locally as well and it does the trick. I'll merge this in when the comments are addressed.

@robertojrojas robertojrojas merged commit 47c5661 into aquasecurity:master Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants