Warn if kubectl can't autodetect the version #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #656 +/- ##
==========================================
- Coverage 66.51% 64.91% -1.61%
==========================================
Files 12 12
Lines 1117 1120 +3
==========================================
- Hits 743 727 -16
- Misses 336 357 +21
+ Partials 38 36 -2
Continue to review full report at Codecov.
|
yoavrotems
reviewed
Aug 3, 2020
caruccio
pushed a commit
to getupcloud/kube-bench
that referenced
this pull request
Feb 19, 2021
* Add warning if lacking kubeconfig for auto-detect * Only run getbenchmarkVersion once * Remove call to continueWithError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #655. This outputs a warning if kubectl doesn't have access to kubeconfig and can't autodetect the version.
Modified code to only run
getBenchmarkVersion()once per command, so that this new warning doesn't get emitted four times! (Note that theloadConfig()function can get called several times from the code in root.go)This PR doesn't update the default version yet so it's not a full fix for the issue.