Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default Kubernetes to 1.18 #657

Merged
merged 4 commits into from
Aug 4, 2020
Merged

Update default Kubernetes to 1.18 #657

merged 4 commits into from
Aug 4, 2020

Conversation

lizrice
Copy link
Contributor

@lizrice lizrice commented Aug 3, 2020

No description provided.

@lizrice lizrice added this to the v0.4.0 milestone Aug 3, 2020
@lizrice lizrice requested a review from yoavrotems August 3, 2020 19:25
yoavrotems
yoavrotems previously approved these changes Aug 4, 2020
Copy link
Contributor

@yoavrotems yoavrotems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM even though travis build is failing

@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #657 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #657   +/-   ##
=======================================
  Coverage   66.51%   66.51%           
=======================================
  Files          12       12           
  Lines        1117     1117           
=======================================
  Hits          743      743           
  Misses        336      336           
  Partials       38       38           
Impacted Files Coverage Δ
cmd/root.go 49.36% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e69b2fe...e573c1f. Read the comment docs.

Copy link
Contributor

@yoavrotems yoavrotems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pass all tests :) LGTM

@yoavrotems yoavrotems merged commit b0d175b into master Aug 4, 2020
@lizrice lizrice deleted the new-default branch December 17, 2020 13:47
caruccio pushed a commit to getupcloud/kube-bench that referenced this pull request Feb 19, 2021
* Update default Kubernetes to 1.18

* Add missing mapping

* Show pod logs on failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants