-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve test clarity #675
Conversation
Codecov Report
@@ Coverage Diff @@
## master #675 +/- ##
=======================================
Coverage 65.93% 65.93%
=======================================
Files 12 12
Lines 1133 1133
=======================================
Hits 747 747
Misses 350 350
Partials 36 36 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
* read-only-port defaults are correct * Tests that should catch good read-only-port * Rework checks & tests * Linting on issue template YAML * More explicit test for 4.2.4 * Remove verbosity for ease of reading results * Use subtests * Tidy more test cases
make tests
so it's easier to see whether it passes