Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to go version 1.15 #706

Merged
merged 1 commit into from
Oct 3, 2020
Merged

upgrade to go version 1.15 #706

merged 1 commit into from
Oct 3, 2020

Conversation

neha-viswanathan
Copy link
Contributor

Upgrade golang base image to 1.15

lizrice pushed a commit that referenced this pull request Oct 1, 2020
* Add condition to make docker

Build and push Docker image only when pushing to master.

* Update to Golang 1.15

As #706 did, just doing it in my fork to test Travis changes about the build
@neha-viswanathan
Copy link
Contributor Author

@yoavrotems @lizrice should we close this, since it was part of #713 ?

@codecov
Copy link

codecov bot commented Oct 3, 2020

Codecov Report

Merging #706 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #706   +/-   ##
=======================================
  Coverage   63.31%   63.31%           
=======================================
  Files          12       12           
  Lines        1044     1044           
=======================================
  Hits          661      661           
  Misses        344      344           
  Partials       39       39           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deecf62...dc84481. Read the comment docs.

@lizrice
Copy link
Contributor

lizrice commented Oct 3, 2020

I’m going to accept this - I think it’s better not to specify the patch version .0, as we might miss a security release version

Copy link
Contributor

@lizrice lizrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@lizrice lizrice merged commit 90b7ae6 into aquasecurity:master Oct 3, 2020
caruccio pushed a commit to getupcloud/kube-bench that referenced this pull request Feb 19, 2021
* Add condition to make docker

Build and push Docker image only when pushing to master.

* Update to Golang 1.15

As aquasecurity#706 did, just doing it in my fork to test Travis changes about the build
caruccio pushed a commit to getupcloud/kube-bench that referenced this pull request Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants