Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add Kubernetes integration test #28

Merged
merged 2 commits into from Jun 24, 2019
Merged

test: Add Kubernetes integration test #28

merged 2 commits into from Jun 24, 2019

Conversation

danielpacak
Copy link
Contributor

@danielpacak danielpacak commented Jun 22, 2019

A scaffold for integration tests against real Kubernetes API. The integration test runs two containers in docker compose: 1) K3S, i.e. lean Kubernetes cluster; 2) Test executable itself. Both containers share KUBECONFIG via shared-data volume and KUBECONFIG env.

It's also integrated with TravisCI, i.e. runs on each PR and merge to master.

@codecov-io
Copy link

codecov-io commented Jun 22, 2019

Codecov Report

Merging #28 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #28   +/-   ##
=======================================
  Coverage   65.13%   65.13%           
=======================================
  Files           4        4           
  Lines         370      370           
=======================================
  Hits          241      241           
  Misses        123      123           
  Partials        6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d076d34...c0d928c. Read the comment docs.

@danielpacak danielpacak changed the title Integration test feat: Add Kubernetes integration test Jun 22, 2019
@danielpacak danielpacak changed the title feat: Add Kubernetes integration test test: Add Kubernetes integration test Jun 22, 2019
@danielpacak danielpacak requested a review from lizrice June 24, 2019 07:30
Copy link
Contributor

@lizrice lizrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

t.Skip("Integration test")
}

// TODO Wait for KUBECONFIG
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a TODO here, but I'm OK with it

@lizrice lizrice merged commit b9b4181 into aquasecurity:master Jun 24, 2019
@danielpacak danielpacak deleted the integration-test branch June 24, 2019 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants