Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default filter callbacks #293

Closed
2 tasks done
geyslan opened this issue Feb 20, 2023 · 0 comments · Fixed by #294
Closed
2 tasks done

Remove default filter callbacks #293

geyslan opened this issue Feb 20, 2023 · 0 comments · Fixed by #294
Assignees
@geyslan
Labels
feature New feature or request

Comments

@geyslan
Copy link
Member

geyslan commented Feb 20, 2023 •
edited
Loading

Description

As we now have libbpfgo log callbacks, the logic for filtering must reside in the consumer.

  • remove default filter callbacks
  • change tests to better exemplify the callbacks usage

Additional details

Context:
@geyslan geyslan added the feature New feature or request label Feb 20, 2023
@geyslan geyslan self-assigned this Feb 20, 2023
This was referenced Feb 20, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geyslan geyslan

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

logger_cb: remove default callbacks geyslan/libbpfgo
1 participant
@geyslan