Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logger: set libbpfgo logger callback #2663

Merged
merged 2 commits into from
Feb 21, 2023
Merged

logger: set libbpfgo logger callback #2663

merged 2 commits into from
Feb 21, 2023

Conversation

geyslan
Copy link
Member

@geyslan geyslan commented Jan 31, 2023 •
edited
Loading

Initial Checklist

  • There is an issue describing the need for this PR.

Description (git log)

commit f965b78

libbpfgo: bump to 8f83f25

From this hash, libbpfgo publicizes its log callback API.

commit f14050d

chore: set libbpfgo logger callback

Depends on

Type of change

  • New feature (non-breaking change adding functionality).

Context

Fixes: #2417

@geyslan geyslan self-assigned this Jan 31, 2023
@geyslan
Copy link
Member Author

geyslan commented Jan 31, 2023 •
edited
Loading

After aquasecurity/libbpfgo#284 merge, will need other commit bumping libbpfgo version.

Checks failed due to that. https://github.com/aquasecurity/tracee/actions/runs/4056708142/jobs/6981532888

@geyslan geyslan marked this pull request as draft January 31, 2023 17:30
@geyslan geyslan changed the title chore: set libbpfgo logger callback logger: set libbpfgo logger callback Feb 11, 2023
@geyslan geyslan mentioned this pull request Feb 20, 2023
Merged
@geyslan
chore: set libbpfgo logger callback
f14050d
@geyslan
libbpfgo: bump to 8f83f25
f965b78 
From this hash, libbpfgo publicizes its log callback API.
@geyslan geyslan marked this pull request as ready for review February 20, 2023 19:09
@geyslan
Copy link
Member Author

geyslan commented Feb 20, 2023

After merging this and #2663, I'll open an issue in both projects to tackle the hard-coded filters move.

aquasecurity/libbpfgo#284 (comment)

@rafaeldtinoco rafaeldtinoco mentioned this pull request Feb 21, 2023
Closed
rafaeldtinoco
rafaeldtinoco approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@rafaeldtinoco rafaeldtinoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafaeldtinoco rafaeldtinoco merged commit 22f93bc into aquasecurity:main Feb 21, 2023
@geyslan geyslan deleted the libbpfgo-log-callbacks branch May 29, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaeldtinoco rafaeldtinoco rafaeldtinoco approved these changes

@yanivagman yanivagman Awaiting requested review from yanivagman

@AlonZivony AlonZivony Awaiting requested review from AlonZivony

@NDStrahilevitz NDStrahilevitz Awaiting requested review from NDStrahilevitz

Assignees

@geyslan geyslan

Labels
kind/chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Print libbpf and libbpfgo logs to logger
2 participants
@geyslan @rafaeldtinoco