Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump libbpf to map creation upstream fix #305

Closed
geyslan opened this issue Mar 23, 2023 · 1 comment · Fixed by #306
Closed

bump libbpf to map creation upstream fix #305

geyslan opened this issue Mar 23, 2023 · 1 comment · Fixed by #306
Assignees
@geyslan
Labels
bug Something isn't working

Comments

@geyslan
Copy link
Member

geyslan commented Mar 23, 2023 •
edited

libbpf v1.1.0 is failing with kernels without BPF_F_MMAPABLE support.

libbpf must be bumped to the upstream:

Context:
@geyslan geyslan added the bug Something isn't working label Mar 23, 2023
@geyslan geyslan self-assigned this Mar 23, 2023
geyslan added a commit to geyslan/libbpfgo that referenced this issue Mar 23, 2023
@geyslan
libbpf: bump to ce8d078
ca4c7f5 
This is a minor bump to include the following libbpf fix:

  libbpf: Fix map creation flags sanitization

  As BPF_F_MMAPABLE flag is now conditionnaly set (by map_is_mmapable),
  it should not be toggled but disabled if not supported by kernel.

Fixes: aquasecurity#305
@geyslan geyslan mentioned this issue Mar 23, 2023
Merged
@geyslan
Copy link
Member Author

geyslan commented Mar 23, 2023

We can't checkout libbpf/libbpf@ce8d078, since there were other changes related to map what bumped it to 1.2 while libbpf remained 1.1. See build error:

image

So the actual bump needs to be to 1.2 - libbpf/libbpf@b2e29a1.

geyslan added a commit to geyslan/libbpfgo that referenced this issue Mar 23, 2023
@geyslan
libbpf: bump to b2e29a1
1470d4a 
This is a minor bump to include the following libbpf fix (and all
the related changes in libbpf submodule):

  libbpf: Fix map creation flags sanitization

  As BPF_F_MMAPABLE flag is now conditionnaly set (by map_is_mmapable),
  it should not be toggled but disabled if not supported by kernel.

Fixes: aquasecurity#305
rafaeldtinoco pushed a commit that referenced this issue Mar 24, 2023
@geyslan
libbpf: bump to b2e29a1 (#306)
1fd6937 
This is a minor bump to include the following libbpf fix (and all
the related changes in libbpf submodule):

  libbpf: Fix map creation flags sanitization

  As BPF_F_MMAPABLE flag is now conditionnaly set (by map_is_mmapable),
  it should not be toggled but disabled if not supported by kernel.

Fixes: #305
@geyslan geyslan mentioned this issue Mar 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geyslan geyslan

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

libbpf: bump to b2e29a1 geyslan/libbpfgo
1 participant
@geyslan