Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps #431

Merged
merged 5 commits into from
May 24, 2024
Merged

Bumps #431

merged 5 commits into from
May 24, 2024

Conversation

geyslan
Copy link
Member

@geyslan geyslan commented May 22, 2024

commit 517e2d5

chore: code format as clang-format-14

commit 46560d5

chore: bump ubuntu images, go, clang, actions...

clang-format pinned to the same version of the clang compiler.

Co-authored-by: Raphael Campos <raphaelcampos.rp@gmail.com>

commit 7b0db19

chore: add libzstd-dev to preparation

commit 098f20b

fix(build): set required ldflags

For static build, get pc info from the freshly built libbpf.a instead of
the system one.
For dynamic build, set only the required ldflags for the system libbpf.

commit 76bd3af

chore: bump go.mod files

go version to 1.22.0
go toolchain to 1.22.3

go version to 1.22.0
go toolchain to 1.22.3
@geyslan geyslan added bug Something isn't working chore labels May 22, 2024
@geyslan geyslan requested a review from rscampos May 22, 2024 21:01
@geyslan geyslan self-assigned this May 22, 2024
For static build, get pc info from the freshly built libbpf.a instead of
the system one.
For dynamic build, set only the required ldflags for the system libbpf.
@geyslan geyslan force-pushed the bumps branch 12 times, most recently from f89f342 to 85bc882 Compare May 23, 2024 11:48
@geyslan geyslan marked this pull request as ready for review May 23, 2024 11:49
@geyslan
Copy link
Member Author

geyslan commented May 23, 2024

@rscampos it would be nice to test it on arm64.

@geyslan geyslan force-pushed the bumps branch 2 times, most recently from 32eec76 to 143d1c2 Compare May 24, 2024 21:29
@geyslan
Copy link
Member Author

geyslan commented May 24, 2024

@rscampos as you mentioned in geyslan#8 (comment), next step is to decide what style .clang-format will enforce to us. 👍🏼

geyslan and others added 2 commits May 24, 2024 19:21
clang-format pinned to the same version of the clang compiler.

Co-authored-by: Raphael Campos <raphaelcampos.rp@gmail.com>
@rscampos
Copy link
Collaborator

@geyslan I did some tests on arm... just need to change to clang-format-14, all good :)

Copy link
Collaborator

@rscampos rscampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geyslan geyslan merged commit daeb5d0 into aquasecurity:main May 24, 2024
11 checks passed
@geyslan geyslan deleted the bumps branch May 24, 2024 23:11
@@ -1,6 +1,8 @@
module github.com/aquasecurity/libbpfgo

go 1.21
go 1.22.0

This comment was marked as resolved.

This comment was marked as outdated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are not supposed to dictate what go version is necessary for the consumers unless it's actually necessary:

No matter how good the latest Go version is, if it's not a requirement, you are not supposed to force it. You set the minimum supported Go version instead. Go supports two major releases at any time and it seems reasonable to do at least the same thing.

People with patched go versions might not have an ability to upgrade to the latest release.

I don't think there's a good reason to set toolchain for a library ever.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're absolutely right. I'm going to revert (soon) this PR by splitting the fix and other chores into their own PRs. 👍🏼

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I appreciate it.

@geyslan geyslan mentioned this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants