Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering of ConfigAuditReport with exempted containers #71

Merged

Conversation

yurrriq
Copy link
Contributor

@yurrriq yurrriq commented Feb 24, 2022

Fixes #70. I tested this on my local machine and the ConfigAuditReport in question now renders correctly with this change.

FYI I notice probably the same issue in https://github.com/aquasecurity/starboard-lens-extension/blob/v0.4.0/src/vulnerabilityreports/list.tsx#L73-L77

@yurrriq yurrriq marked this pull request as ready for review February 24, 2022 02:43
@danielpacak danielpacak self-requested a review February 24, 2022 13:24
Copy link
Contributor

@danielpacak danielpacak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch and thank you for the fix @yurrriq !

@danielpacak danielpacak merged commit 585c8ba into aquasecurity:main Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read property 'length' of null in ConfigAuditReports details
2 participants