refactor: Move Polaris package under plugin (#419)

Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>

pkg/cmd/scan_configaudit.go

@@ -3,8 +3,8 @@ package cmd
 import (
 	"context"
 
-	"github.com/aquasecurity/starboard/pkg/config"
 	"github.com/aquasecurity/starboard/pkg/configauditreport"
+	"github.com/aquasecurity/starboard/pkg/plugin"
 	"github.com/aquasecurity/starboard/pkg/starboard"
 	"github.com/spf13/cobra"
 	"k8s.io/cli-runtime/pkg/genericclioptions"
@@ -62,11 +62,11 @@ func ScanConfigAuditReports(buildInfo starboard.BuildInfo, cf *genericclioptions
 		if err != nil {
 			return err
 		}
-		plugin, err := config.GetConfigAuditReportPlugin(buildInfo, starboardConfig)
+		instance, err := plugin.GetConfigAuditReportPlugin(buildInfo, starboardConfig)
 		if err != nil {
 			return err
 		}
-		scanner := configauditreport.NewScanner(scheme, kubeClientset, opts, plugin)
+		scanner := configauditreport.NewScanner(scheme, kubeClientset, opts, instance)
 		report, err := scanner.Scan(ctx, workload, gvk)
 		if err != nil {
 			return err

pkg/cmd/scan_vulnerabilities.go

@@ -4,7 +4,7 @@ import (
 	"context"
 	"fmt"
 
-	"github.com/aquasecurity/starboard/pkg/config"
+	"github.com/aquasecurity/starboard/pkg/plugin"
 	"github.com/aquasecurity/starboard/pkg/starboard"
 	"github.com/aquasecurity/starboard/pkg/vulnerabilityreport"
 	"github.com/spf13/cobra"
@@ -98,15 +98,15 @@ func ScanVulnerabilityReports(buildInfo starboard.BuildInfo, cf *genericclioptio
 		if err != nil {
 			return err
 		}
-		plugin, err := config.GetVulnerabilityReportPlugin(buildInfo, starboardConfig)
+		instance, err := plugin.GetVulnerabilityReportPlugin(buildInfo, starboardConfig)
 		if err != nil {
 			return err
 		}
 		reports, err := vulnerabilityreport.NewScanner(
 			scheme,
 			kubeClientset,
 			opts,
-			plugin).Scan(ctx, workload)
+			instance).Scan(ctx, workload)
 		if err != nil {
 			return err
 		}

pkg/operator/operator.go

@@ -4,13 +4,13 @@ import (
 	"context"
 	"fmt"
 
-	"github.com/aquasecurity/starboard/pkg/config"
 	"github.com/aquasecurity/starboard/pkg/configauditreport"
 	"github.com/aquasecurity/starboard/pkg/ext"
 	"github.com/aquasecurity/starboard/pkg/kube"
 	"github.com/aquasecurity/starboard/pkg/kubebench"
 	"github.com/aquasecurity/starboard/pkg/operator/controller"
 	"github.com/aquasecurity/starboard/pkg/operator/etc"
+	"github.com/aquasecurity/starboard/pkg/plugin"
 	"github.com/aquasecurity/starboard/pkg/starboard"
 	"github.com/aquasecurity/starboard/pkg/vulnerabilityreport"
 	"k8s.io/client-go/kubernetes"
@@ -122,7 +122,7 @@ func Run(buildInfo starboard.BuildInfo, operatorConfig etc.Config) error {
 	logsReader := kube.NewLogsReader(kubeClientset)
 	secretsReader := kube.NewControllerRuntimeSecretsReader(mgr.GetClient())
 
-	vulnerabilityReportPlugin, err := config.GetVulnerabilityReportPlugin(buildInfo, starboardConfig)
+	vulnerabilityReportPlugin, err := plugin.GetVulnerabilityReportPlugin(buildInfo, starboardConfig)
 	if err != nil {
 		return err
 	}
@@ -141,7 +141,7 @@ func Run(buildInfo starboard.BuildInfo, operatorConfig etc.Config) error {
 		return fmt.Errorf("unable to setup vulnerabilityreport reconciler: %w", err)
 	}
 
-	configAuditReportPlugin, err := config.GetConfigAuditReportPlugin(buildInfo, starboardConfig)
+	configAuditReportPlugin, err := plugin.GetConfigAuditReportPlugin(buildInfo, starboardConfig)
 	if err != nil {
 		return err
 	}

pkg/plugin/doc.go

@@ -0,0 +1 @@
+package plugin

pkg/config/config.go → pkg/plugin/factory.go

@@ -1,12 +1,12 @@
-package config
+package plugin
 
 import (
 	"fmt"
 
 	"github.com/aquasecurity/starboard/pkg/aqua"
 	"github.com/aquasecurity/starboard/pkg/configauditreport"
 	"github.com/aquasecurity/starboard/pkg/ext"
-	"github.com/aquasecurity/starboard/pkg/polaris"
+	"github.com/aquasecurity/starboard/pkg/plugin/polaris"
 	"github.com/aquasecurity/starboard/pkg/starboard"
 	"github.com/aquasecurity/starboard/pkg/trivy"
 	"github.com/aquasecurity/starboard/pkg/vulnerabilityreport"

pkg/plugin/factory_test.go

@@ -0,0 +1 @@
+package plugin_test

pkg/plugin/polaris/doc.go

@@ -0,0 +1,2 @@
+// The polaris package provides primitives for working with Polaris.
+package polaris

pkg/polaris/plugin_test.go → pkg/plugin/polaris/plugin_test.go

@@ -8,7 +8,7 @@ import (
 	"github.com/aquasecurity/starboard/pkg/apis/aquasecurity/v1alpha1"
 	"github.com/aquasecurity/starboard/pkg/ext"
 	"github.com/aquasecurity/starboard/pkg/kube"
-	"github.com/aquasecurity/starboard/pkg/polaris"
+	"github.com/aquasecurity/starboard/pkg/plugin/polaris"
 	"github.com/aquasecurity/starboard/pkg/starboard"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"

pkg/trivy/doc.go

@@ -0,0 +1,2 @@
+// The trivy package provides primitives for working with Trivy.
+package trivy