Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add app.kubernetes.io/managed-by=starboard label to objects created by Starboard #121

Merged
merged 1 commit into from
Aug 14, 2020

Conversation

danielpacak
Copy link
Contributor

For troubleshooting and to do a proper cleanup even without running the starbaord cleanup subcommand

Signed-off-by: Daniel Pacak pacak.daniel@gmail.com

…ated by Starboard

Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #121 into master will decrease coverage by 0.13%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
- Coverage   13.01%   12.87%   -0.14%     
==========================================
  Files          30       30              
  Lines        1414     1429      +15     
==========================================
  Hits          184      184              
- Misses       1222     1237      +15     
  Partials        8        8              
Impacted Files Coverage Δ
pkg/kube/cr_manager.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a7c523...abc5694. Read the comment docs.

Copy link
Contributor

@danielsagi danielsagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielpacak danielpacak merged commit 32f8b1b into master Aug 14, 2020
@danielpacak danielpacak deleted the add_recommended_labels branch August 14, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants