Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 244 - Add affinity to the linux node by default #289

Merged
merged 4 commits into from
Jan 8, 2021

Conversation

krol3
Copy link
Contributor

@krol3 krol3 commented Dec 23, 2020

This PR add a default affinity to create the pod in the linux nodes.

Related the issue-244

@codecov
Copy link

codecov bot commented Dec 23, 2020

Codecov Report

Merging #289 (fb6ad9c) into main (10a7cc4) will decrease coverage by 0.34%.
The diff coverage is 15.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #289      +/-   ##
==========================================
- Coverage   62.52%   62.18%   -0.35%     
==========================================
  Files          57       57              
  Lines        2754     2774      +20     
==========================================
+ Hits         1722     1725       +3     
- Misses        807      823      +16     
- Partials      225      226       +1     
Impacted Files Coverage Δ
pkg/kubehunter/scanner.go 0.00% <0.00%> (ø)
pkg/starboard/config.go 68.69% <0.00%> (-8.76%) ⬇️
pkg/cmd/scan_ciskubebench.go 54.34% <25.00%> (-2.80%) ⬇️
pkg/polaris/scanner.go 87.20% <100.00%> (+0.10%) ⬆️
pkg/trivy/scanner.go 73.06% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10a7cc4...fb6ad9c. Read the comment docs.

Copy link
Contributor

@danielpacak danielpacak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krol3 I left a few comments. I also notices that there are failing unit tests.

pkg/cmd/scan_ciskubebench.go Outdated Show resolved Hide resolved
pkg/kubebench/scanner.go Outdated Show resolved Hide resolved
pkg/starboard/config.go Outdated Show resolved Hide resolved
@danielpacak danielpacak merged commit b73bc8c into aquasecurity:main Jan 8, 2021
@krol3 krol3 deleted the issue-244 branch January 8, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants