Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Delete StoreInterface in favour of ReadWriter #321

Merged
merged 1 commit into from
Jan 8, 2021

Conversation

danielpacak
Copy link
Contributor

Signed-off-by: Daniel Pacak pacak.daniel@gmail.com

@codecov
Copy link

codecov bot commented Jan 8, 2021

Codecov Report

Merging #321 (c08d15b) into main (b73bc8c) will increase coverage by 0.02%.
The diff coverage is 81.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #321      +/-   ##
==========================================
+ Coverage   62.18%   62.20%   +0.02%     
==========================================
  Files          57       56       -1     
  Lines        2774     2773       -1     
==========================================
  Hits         1725     1725              
+ Misses        823      822       -1     
  Partials      226      226              
Impacted Files Coverage Δ
pkg/operator/controller/analyzer.go 70.27% <ø> (ø)
pkg/starboard/config.go 69.29% <0.00%> (+0.60%) ⬆️
pkg/vulnerabilityreport/scanner.go 73.46% <ø> (ø)
pkg/vulnerabilityreport/writer.go 83.60% <82.75%> (-0.77%) ⬇️
pkg/operator/controller/reconciler.go 58.46% <100.00%> (ø)
pkg/operator/operator.go 52.80% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b73bc8c...c08d15b. Read the comment docs.

Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
@danielpacak danielpacak force-pushed the refactor_vulnerabilityreports_readwriter branch from a12b3c6 to c08d15b Compare January 8, 2021 20:47
@danielpacak danielpacak merged commit 965b180 into main Jan 8, 2021
@danielpacak danielpacak deleted the refactor_vulnerabilityreports_readwriter branch January 8, 2021 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant