Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Delete WorkloadVulnerabilities type #322

Merged
merged 1 commit into from
Jan 11, 2021

Conversation

danielpacak
Copy link
Contributor

Signed-off-by: Daniel Pacak pacak.daniel@gmail.com

@codecov
Copy link

codecov bot commented Jan 8, 2021

Codecov Report

Merging #322 (710ecbd) into main (965b180) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #322   +/-   ##
=======================================
  Coverage   62.20%   62.20%           
=======================================
  Files          56       56           
  Lines        2773     2773           
=======================================
  Hits         1725     1725           
  Misses        822      822           
  Partials      226      226           
Impacted Files Coverage Δ
pkg/vulnerabilityreport/writer.go 83.60% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1697c4c...710ecbd. Read the comment docs.

Copy link
Member

@simar7 simar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Just curious how the (now removed .qtpl) template is used within starboard?

@danielpacak
Copy link
Contributor Author

lgtm. Just curious how the (now removed .qtpl) template is used within starboard?

We compile *.qtpl files to Go code with the make compile-templates target. However, I did not remove any template, it's just modified to get rid of references to WorkloadVulnerabilities struct.

Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
@danielpacak danielpacak force-pushed the delete_WorkloadVulnerabilities_type branch from dc882a8 to 710ecbd Compare January 11, 2021 07:02
@danielpacak danielpacak merged commit b0a8932 into main Jan 11, 2021
@danielpacak danielpacak deleted the delete_WorkloadVulnerabilities_type branch January 11, 2021 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants