feat(cli): Provide more details when scan job fails #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #328 +/- ##
==========================================
+ Coverage 65.70% 66.02% +0.32%
==========================================
Files 57 57
Lines 2799 2820 +21
==========================================
+ Hits 1839 1862 +23
+ Misses 720 718 -2
Partials 240 240
Continue to review full report at Codecov.
|
danielpacak
force-pushed
the
cli_watch_events
branch
from
4853f1b
to
9df2360
Compare
Resolves: #70 Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
danielpacak
force-pushed
the
cli_watch_events
branch
from
9df2360
to
8fd54e5
Compare
lizrice
approved these changes
Jan 13, 2021
pkg/kube/pod/manager.go
Outdated
| @@ -159,7 +160,10 @@ func (pw *Manager) GetPodByJob(ctx context.Context, job *batch.Job) (*core.Pod, | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| return &podList.Items[0], nil | |||
| if len(podList.Items) > 0 { | |||
There was a problem hiding this comment.
Any chance podList can be nil?
There was a problem hiding this comment.
In theory if there's no error it won't be nil. However, we're practitioners so I added nil check to the podList 🤣
Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It might happen that a scan job cannot be created. In such cases Starboard CLI hangs forever because it watches the job's status to terminate (JobComplete or JobFailed). However, some failures are reported as Kubernetes events associated with the scan job.
This change adds the events informer to watch events associated with a scan job, and terminate the program when the event of type EventTypeWarning (= error for Kubernetes) is detected.
To reproduce you can delete the starboard service account in the starborad namespace:
Before
After
Resolves: #70
Signed-off-by: Daniel Pacak pacak.daniel@gmail.com