Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Define interface for resource configuration checkers #333

Merged
merged 3 commits into from
Jan 13, 2021
Merged

refactor: Define interface for resource configuration checkers #333

merged 3 commits into from
Jan 13, 2021

Conversation

danielpacak
Copy link
Contributor

@danielpacak danielpacak commented Jan 12, 2021 •
edited

This is a preliminary step to onboard Popeye or any other configuration auditing tool and reuse code to integrate Polaris with Starboard Operator.

@danielpacak danielpacak changed the title Separate generic code from Polaris specific implementation refactor: Define interface for resource configuration checkers Jan 12, 2021
@danielpacak
refactor: Define interface for resource configuration checkers
fe99938 
Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
@codecov
Copy link

codecov bot commented Jan 12, 2021 •
edited

Codecov Report

Merging #333 (a5ab1ce) into main (5af029b) will increase coverage by 0.13%.
The diff coverage is 97.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #333      +/-   ##
==========================================
+ Coverage   65.70%   65.83%   +0.13%     
==========================================
  Files          57       57              
  Lines        2799     2810      +11     
==========================================
+ Hits         1839     1850      +11     
  Misses        720      720              
  Partials      240      240
Impacted Files Coverage Δ
pkg/polaris/scanner.go 88.14% <97.14%> (+0.94%) ⬆️
pkg/cmd/scan_configaudit.go 51.35% <100.00%> (+1.35%) ⬆️
pkg/vulnerabilityreport/scanner.go 73.46% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5af029b...a5ab1ce. Read the comment docs.

simar7
simar7 reviewed Jan 13, 2021
View reviewed changes
pkg/polaris/scanner_test.go Outdated Show resolved Hide resolved
simar7
simar7 approved these changes Jan 13, 2021
View reviewed changes
Copy link
Member

@simar7 simar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits but overall lgtm

danielpacak and others added 2 commits January 13, 2021 08:05
@danielpacak @simar7
Update pkg/configauditreport/plugin.go
2d7aa2a 
Co-authored-by: Simarpreet Singh <simar@linux.com>
@danielpacak
Apply review comments
a5ab1ce 
Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
@danielpacak danielpacak merged commit 0882c9e into main Jan 13, 2021
@danielpacak danielpacak deleted the configaudit_interface branch January 13, 2021 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simar7 simar7 simar7 approved these changes

Assignees

@simar7 simar7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielpacak @simar7