Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add passing checks count to configauditreport summary #348

Conversation

mlevesquedion
Copy link
Contributor

Fixes #334.

Here is the output I get for the nginx deployment from the getting started docs:

$ kubectl create deployment nginx --image nginx:1.16
$ starboard scan vulnerabilityreports deployment/nginx
$ kubectl get configauditreports.aquasecurity.github.io -o wide
NAME               SCANNER   AGE   PASS   DANGER   WARNING
deployment-nginx   Polaris   1s    9      0        8

@codecov
Copy link

codecov bot commented Jan 17, 2021

Codecov Report

Merging #348 (a2205d0) into main (725dd4f) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #348      +/-   ##
==========================================
+ Coverage   66.16%   66.18%   +0.02%     
==========================================
  Files          57       57              
  Lines        2843     2845       +2     
==========================================
+ Hits         1881     1883       +2     
  Misses        721      721              
  Partials      241      241              
Impacted Files Coverage Δ
pkg/polaris/plugin.go 90.08% <100.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 725dd4f...a2205d0. Read the comment docs.

@danielpacak danielpacak self-requested a review January 17, 2021 09:33
Copy link
Contributor

@danielpacak danielpacak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thank you @mlevesquedion and sorry for the trouble with conflicting changes in Polars tests.

@danielpacak danielpacak merged commit 585c4b6 into aquasecurity:main Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add passing checks count to the ConfigAuditReport summary
2 participants