Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use kube.LogsReader to parse logs and termination statuses #353

Merged
merged 1 commit into from
Jan 20, 2021

Conversation

danielpacak
Copy link
Contributor

Signed-off-by: Daniel Pacak pacak.daniel@gmail.com

@codecov
Copy link

codecov bot commented Jan 19, 2021

Codecov Report

Merging #353 (c4d4a0b) into main (3a548ef) will increase coverage by 0.41%.
The diff coverage is 60.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #353      +/-   ##
==========================================
+ Coverage   66.71%   67.12%   +0.41%     
==========================================
  Files          57       57              
  Lines        2866     2841      -25     
==========================================
- Hits         1912     1907       -5     
+ Misses        714      701      -13     
+ Partials      240      233       -7     
Impacted Files Coverage Δ
pkg/operator/controller/job/job_controller.go 50.00% <0.00%> (+0.87%) ⬆️
pkg/kube/runnable_job.go 56.16% <38.46%> (-6.34%) ⬇️
pkg/kube/logs.go 38.88% <38.88%> (ø)
pkg/kube/pod/manager.go 40.00% <53.33%> (+4.28%) ⬆️
pkg/operator/controller/reconciler.go 59.64% <80.00%> (+1.18%) ⬆️
pkg/configauditreport/scanner.go 81.94% <100.00%> (+1.38%) ⬆️
pkg/kube/object.go 62.50% <100.00%> (+11.33%) ⬆️
pkg/kubebench/scanner.go 92.61% <100.00%> (+0.04%) ⬆️
pkg/kubehunter/scanner.go 83.54% <100.00%> (+0.21%) ⬆️
pkg/operator/operator.go 53.84% <100.00%> (+1.03%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83e9a56...c4d4a0b. Read the comment docs.

Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
@danielpacak danielpacak changed the title refactor: Use one kube.LogsReader refactor: Use kube.LogsReader to parse logs and termination statuses Jan 20, 2021
@danielpacak danielpacak merged commit 27a2885 into main Jan 20, 2021
@danielpacak danielpacak deleted the refactor_logs_reader branch January 20, 2021 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant