Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update deployment descriptors and docs #358

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

danielpacak
Copy link
Contributor

@danielpacak danielpacak commented Jan 22, 2021

Apologies for mixing changes to docs and other chores, but I was reading the docs to test the operator.

Signed-off-by: Daniel Pacak pacak.daniel@gmail.com

@codecov
Copy link

codecov bot commented Jan 22, 2021

Codecov Report

Merging #358 (c2c71f7) into main (89a8ceb) will increase coverage by 0.15%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #358      +/-   ##
==========================================
+ Coverage   67.35%   67.50%   +0.15%     
==========================================
  Files          58       58              
  Lines        3057     3059       +2     
==========================================
+ Hits         2059     2065       +6     
+ Misses        745      741       -4     
  Partials      253      253              
Impacted Files Coverage Δ
pkg/operator/controller/configauditreport.go 62.70% <0.00%> (-0.69%) ⬇️
pkg/operator/controller/vulnerabilityreport.go 62.67% <0.00%> (+2.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89a8ceb...c2c71f7. Read the comment docs.

@danielpacak danielpacak force-pushed the update-deployment-descriptors branch 3 times, most recently from 44525a0 to 6c6f9e2 Compare January 26, 2021 10:18
Copy link
Contributor

@lizrice lizrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of suggestions to look at but bascially LGTM!

deploy/crd/configauditreports.crd.yaml Show resolved Hide resolved
docs/operator/getting-started.md Outdated Show resolved Hide resolved
docs/operator/getting-started.md Outdated Show resolved Hide resolved
docs/operator/getting-started.md Outdated Show resolved Hide resolved
docs/operator/installation/olm.md Show resolved Hide resolved
docs/operator/installation/olm.md Show resolved Hide resolved
deploy/init/01-starboard.ns.yaml Show resolved Hide resolved
Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
@danielpacak danielpacak merged commit 110c372 into main Jan 26, 2021
@danielpacak danielpacak deleted the update-deployment-descriptors branch January 26, 2021 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants