Make kubehunter quick config param optional #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #388 +/- ##
==========================================
- Coverage 68.47% 68.27% -0.20%
==========================================
Files 58 58
Lines 3061 3061
==========================================
- Hits 2096 2090 -6
- Misses 709 714 +5
- Partials 256 257 +1
Continue to review full report at Codecov.
|
danielpacak
approved these changes
Feb 12, 2021
mlevesquedion
deleted the
make-kubehunter-quick-config-param-optional
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a potential issue with the
kube-hunter.quickconfiguration param. It doesn't make much sense for this parameter to be required, since it's a fairly specific setting that a significant portion of users may not care about.(This PR was inspired by #386.)