Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(operator): Integrate kube-bench #404

Merged
merged 2 commits into from
Feb 23, 2021
Merged

feat(operator): Integrate kube-bench #404

merged 2 commits into from
Feb 23, 2021

Conversation

danielpacak
Copy link
Contributor

Resolves: #263

Signed-off-by: Daniel Pacak pacak.daniel@gmail.com

@codecov
Copy link

codecov bot commented Feb 17, 2021

Codecov Report

Merging #404 (861edbf) into main (275e215) will decrease coverage by 0.09%.
The diff coverage is 63.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #404      +/-   ##
==========================================
- Coverage   67.89%   67.79%   -0.10%     
==========================================
  Files          58       59       +1     
  Lines        3105     3295     +190     
==========================================
+ Hits         2108     2234     +126     
- Misses        736      781      +45     
- Partials      261      280      +19     
Impacted Files Coverage Δ
pkg/operator/controller/vulnerabilityreport.go 58.96% <0.00%> (-3.72%) ⬇️
pkg/operator/etc/config.go 72.72% <ø> (ø)
pkg/operator/controller/ciskubebenchreport.go 62.50% <62.50%> (ø)
pkg/operator/operator.go 58.41% <73.33%> (+3.35%) ⬆️
pkg/kubebench/scanner.go 90.36% <100.00%> (ø)
pkg/operator/controller/configauditreport.go 67.02% <100.00%> (+4.31%) ⬆️
pkg/operator/predicate/predicate.go 91.22% <100.00%> (+0.66%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 275e215...8a432d9. Read the comment docs.

@danielpacak danielpacak force-pushed the operator_kube-bench branch 10 times, most recently from 3a0a754 to 4a743b7 Compare February 22, 2021 15:57
@danielpacak danielpacak marked this pull request as ready for review February 22, 2021 15:57
Resolves: #263

Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
@@ -43,13 +43,15 @@ spec:
- name: OPERATOR_LOG_DEV_MODE
value: "false"
- name: OPERATOR_CONCURRENT_SCAN_JOBS_LIMIT
value: "3"
value: "10"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're running 3 different scanners now, so I think it's worth bumping up the default limit

pkg/operator/operator.go Outdated Show resolved Hide resolved
Co-authored-by: Teppei Fukuda <knqyf263@gmail.com>
Copy link
Contributor

@knqyf263 knqyf263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@danielpacak danielpacak merged commit 001ee2c into main Feb 23, 2021
@danielpacak danielpacak deleted the operator_kube-bench branch February 23, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[operator] Integrate kube-bench scanner
2 participants