refactor: Separate kube-bench -specific code #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #405 +/- ##
==========================================
- Coverage 67.75% 67.69% -0.06%
==========================================
Files 59 58 -1
Lines 3098 3105 +7
==========================================
+ Hits 2099 2102 +3
- Misses 738 741 +3
- Partials 261 262 +1
Continue to review full report at Codecov.
|
danielpacak
commented
Feb 18, 2021
| ) | ||
| // Plugin defines the interface between Starboard and Kubernetes configuration | ||
| // checker with CIS Kubernetes Benchmarks. | ||
| type Plugin interface { |
There was a problem hiding this comment.
Even though there's (and probably will be) only one implementation that relies on Kube-Bench, the purpose of this interface is to share the logic between CLI and the operator in preparation to resolve #263
joebowbeer
reviewed
Jul 4, 2022
| Privileged: pointer.BoolPtr(false), | ||
| AllowPrivilegeEscalation: pointer.BoolPtr(false), | ||
| Capabilities: &corev1.Capabilities{ | ||
| Drop: []corev1.Capability{"all"}, |
There was a problem hiding this comment.
Suggested change
| Drop: []corev1.Capability{"all"}, | |
| Drop: []corev1.Capability{"ALL"}, |
Isn't this supposed to be ALL (caps)?
According to spec, PSA implementation, and most policy rules?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Pacak pacak.daniel@gmail.com