Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): remove logout step #408

Merged
merged 1 commit into from
Feb 22, 2021
Merged

chore(release): remove logout step #408

merged 1 commit into from
Feb 22, 2021

Conversation

knqyf263
Copy link
Contributor

If I understand correctly, docker/login-action@v1 log out from the Docker registry by default. Am I missing something?
https://github.com/docker/login-action#inputs

image
https://github.com/aquasecurity/starboard/runs/1901817059?check_suite_focus=true

@knqyf263 knqyf263 self-assigned this Feb 22, 2021
@codecov
Copy link

codecov bot commented Feb 22, 2021

Codecov Report

Merging #408 (8b26d75) into main (0c9cf08) will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #408      +/-   ##
==========================================
+ Coverage   67.69%   67.89%   +0.19%     
==========================================
  Files          58       58              
  Lines        3105     3105              
==========================================
+ Hits         2102     2108       +6     
+ Misses        741      736       -5     
+ Partials      262      261       -1     
Impacted Files Coverage Δ
pkg/operator/controller/vulnerabilityreport.go 62.67% <0.00%> (+2.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff66e7f...23682ab. Read the comment docs.

@danielpacak
Copy link
Contributor

If I understand correctly, docker/login-action@v1 log out from the Docker registry by default. Am I missing something?
https://github.com/docker/login-action#inputs

image
https://github.com/aquasecurity/starboard/runs/1901817059?check_suite_focus=true

This is correct. Logout step is redundant now. I used to run the docker login command before we refactored to use Docker's GitHub Action.

@danielpacak danielpacak self-requested a review February 22, 2021 10:44
@danielpacak danielpacak merged commit 275e215 into main Feb 22, 2021
@danielpacak danielpacak deleted the knqyf263-patch-1 branch February 22, 2021 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants