Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ConfigMap template for plugins configuration #437

Merged
merged 2 commits into from
Mar 19, 2021
Merged

Add ConfigMap template for plugins configuration #437

merged 2 commits into from
Mar 19, 2021

Conversation

bgoareguer
Copy link
Contributor

Fix #435

@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #437 (4f0fd93) into main (42c8621) will increase coverage by 0.47%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #437      +/-   ##
==========================================
+ Coverage   68.37%   68.85%   +0.47%     
==========================================
  Files          57       57              
  Lines        3371     3371              
==========================================
+ Hits         2305     2321      +16     
+ Misses        785      772      -13     
+ Partials      281      278       -3     
Impacted Files Coverage Δ
pkg/operator/controller/ciskubebenchreport.go 65.68% <0.00%> (+1.18%) ⬆️
pkg/operator/controller/vulnerabilityreport.go 63.67% <0.00%> (+3.30%) ⬆️
pkg/operator/controller/configauditreport.go 69.23% <0.00%> (+3.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42c8621...4f0fd93. Read the comment docs.

@danielpacak danielpacak self-requested a review March 19, 2021 07:48
Copy link
Contributor

@danielpacak danielpacak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested this change @bgoareguer ? I got the following error on my end:

{"level":"error","ts":1616139567.4504297,"logger":"reconciler.configauditreport","msg":"Scan job container","job":"starboard-operator/scan-configauditreport-c4956cb9d","container":"polaris","status.reason":"Error","status.message":"time="2021-03-19T07:39:26Z" level=error msg="Error parsing config at /etc/starboard/polaris.config.yaml: Decoding config failed: error unmarshaling JSON: while decoding JSON: json: cannot unmarshal array into Go struct field Configuration.checks of type config.Severity"\n"

Notice that we mount the polaris.config.yaml key as file at /etc/starboard/polaris.config.yaml in the container of a pod controlled by a can job. I believe the value should be string not object. Compare your change with https://github.com/aquasecurity/starboard/blob/main/deploy/static/05-starboard-operator.config.yaml#L14

@bgoareguer
Copy link
Contributor Author

Sorry, I just started the starboard-operator without deploying a workload to scan.
I reproduced the error and the last commit fixes it.

Copy link
Contributor

@danielpacak danielpacak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bgoareguer LGTM!

@danielpacak danielpacak merged commit d12f369 into aquasecurity:main Mar 19, 2021
@bgoareguer bgoareguer deleted the fix_435 branch March 19, 2021 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some parameters cannot be defined within values.yaml
2 participants