feat: Deleting a VulnerabilityReport should trigger rescan #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #458 +/- ##
==========================================
+ Coverage 69.41% 69.99% +0.57%
==========================================
Files 58 58
Lines 3551 3579 +28
==========================================
+ Hits 2465 2505 +40
+ Misses 801 792 -9
+ Partials 285 282 -3
Continue to review full report at Codecov.
|
danielpacak
force-pushed
the
issue_414_rescan_vulns
branch
2 times, most recently
from
24fa807
to
8e9de4c
Compare
danielpacak
commented
Mar 25, 2021
| Kind: "Pod", | ||
| Name: podName, | ||
| UID: pod.UID, | ||
| APIVersion: "v1", |
There was a problem hiding this comment.
I will create a custom Gomega matcher to assert valid VulnerabilityReports controlled by the given workload
danielpacak
commented
Mar 25, 2021
| @@ -92,7 +92,7 @@ func (b *builder) Get() (v1alpha1.VulnerabilityReport, error) { | |||
| }, | |||
| Report: b.result, | |||
| } | |||
| err = controllerutil.SetOwnerReference(b.owner, &report, b.scheme) | |||
| err = controllerutil.SetControllerReference(b.owner, &report, b.scheme) | |||
There was a problem hiding this comment.
This change is required to use controller-runtime factories out of the box:
err = ctrl.NewControllerManagedBy(mgr).
For(&appv1.ReplicaSet{}).
Owns(&v1alpa1.VulnerabilityReport{}). // whenever we delete vulnerability report owned by a ReplicaSet, the ReplicaSet gets reconciled
Complete(r.reconcileWorkload(workload.kind))
danielpacak
force-pushed
the
issue_414_rescan_vulns
branch
from
8e9de4c
to
2fff116
Compare
itaysk
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #414
Resolves: #451
Signed-off-by: Daniel Pacak pacak.daniel@gmail.com