Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use custom Gomega matcher to assert VulnerabilityReports #461

Merged
merged 1 commit into from
Mar 26, 2021

Conversation

danielpacak
Copy link
Contributor

Signed-off-by: Daniel Pacak pacak.daniel@gmail.com

@danielpacak danielpacak marked this pull request as draft March 25, 2021 17:18
@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #461 (eb69126) into main (98d5ad2) will increase coverage by 0.66%.
The diff coverage is 83.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #461      +/-   ##
==========================================
+ Coverage   69.17%   69.83%   +0.66%     
==========================================
  Files          57       58       +1     
  Lines        3478     3551      +73     
==========================================
+ Hits         2406     2480      +74     
- Misses        788      789       +1     
+ Partials      284      282       -2     
Impacted Files Coverage Δ
itest/matcher/matcher.go 83.56% <83.56%> (ø)
pkg/operator/controller/configauditreport.go 67.61% <0.00%> (+0.95%) ⬆️
pkg/operator/controller/vulnerabilityreport.go 64.48% <0.00%> (+1.40%) ⬆️
pkg/operator/controller/ciskubebenchreport.go 65.76% <0.00%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98d5ad2...eb69126. Read the comment docs.

@danielpacak danielpacak marked this pull request as ready for review March 25, 2021 17:48
@danielpacak danielpacak requested a review from simar7 March 25, 2021 17:48
Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
@danielpacak danielpacak merged commit 2060f7b into main Mar 26, 2021
@danielpacak danielpacak deleted the custom_gomega_matcher branch March 26, 2021 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants