refactor: Embed vulnerabilityreports CRD #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielpacak
commented
Apr 8, 2021
| @@ -12,6 +12,9 @@ spec: | |||
| storage: true | |||
| schema: | |||
| openAPIV3Schema: | |||
| description: | | |||
| VulnerabilityReport summarizes vulnerabilities in application dependencies and operating system packages | |||
There was a problem hiding this comment.
This is just to check that kubectl explain vulnerabilityreports command displays description. We have #409 to document the report schema.
$ kubectl explain vulnerabilityreports
KIND: VulnerabilityReport
VERSION: aquasecurity.github.io/v1alpha1
DESCRIPTION:
VulnerabilityReport summarizes vulnerabilities in application dependencies
and operating system packages built into container images.
FIELDS:
apiVersion <string> -required-
APIVersion defines the versioned schema of this representation of an
object. Servers should convert recognized schemas to the latest internal
value, and may reject unrecognized values. More info:
https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources
kind <string> -required-
Kind is a string value representing the REST resource this object
represents. Servers may infer this from the endpoint the client submits
requests to. Cannot be updated. In CamelCase. More info:
https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds
metadata <Object> -required-
Standard object's metadata. More info:
https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata
report <Object> -required-
Codecov Report
@@ Coverage Diff @@
## main #484 +/- ##
==========================================
+ Coverage 69.95% 70.10% +0.14%
==========================================
Files 62 62
Lines 3988 3990 +2
==========================================
+ Hits 2790 2797 +7
+ Misses 899 895 -4
+ Partials 299 298 -1
Continue to review full report at Codecov.
|
danielpacak
commented
Apr 8, 2021
| ) | ||
|
|
||
| var ( | ||
| //go:embed deploy/crd/vulnerabilityreports.crd.yaml |
There was a problem hiding this comment.
We cannot use relative path that start with . or ./.., therefore this embedded.go is in the top level starboard package
danielpacak
commented
Apr 8, 2021
| @@ -17,208 +11,6 @@ const ( | |||
| VulnerabilityReportListKind = "VulnerabilityReportList" | |||
| ) | |||
|
|
|||
| var ( | |||
| // TODO Once we migrate to Go 1.16 we can use the embed package to load the CRD from ./deploy/crd/vulnerabilityreports.crd.yaml | |||
| VulnerabilityReportsCRD = apiextensionsv1.CustomResourceDefinition{ | |||
There was a problem hiding this comment.
This Go struct literal was a duplicate of deploy/crd/vulnerabilityreports.crd.yaml
danielpacak
force-pushed
the
embed_vulnerabilityreports_crd
branch
2 times, most recently
from
0e843c0
to
583ab45
Compare
This change required bumping up Go from v1.15 to v1.16 to take advantage of embed package. Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
danielpacak
force-pushed
the
embed_vulnerabilityreports_crd
branch
from
583ab45
to
4483ed9
Compare
itaysk
approved these changes
Apr 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change required bumping up Go from v1.15 to v1.16
to take advantage of embed package.
Signed-off-by: Daniel Pacak pacak.daniel@gmail.com