feat: Ensure default config should not create ConfigMap for Polaris when it is not chosen as plugin #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen it is not chosen as plugin Resolves: #524 Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
danielpacak
commented
Apr 23, 2021
| apiVersion: v1 | ||
| kind: ConfigMap | ||
| metadata: | ||
| name: starboard-conftest-config |
There was a problem hiding this comment.
Static YAMLs hardcode config audit plugin to Polaris so we won't create ConfigMap for Conftest
danielpacak
commented
Apr 23, 2021
| @@ -324,67 +325,204 @@ func TestConfigManager_Read(t *testing.T) { | |||
|
|
|||
| func TestConfigManager_EnsureDefault(t *testing.T) { | |||
|
|
|||
| t.Run("Should create ConfigMap with default values, and empty secret", func(t *testing.T) { | |||
| t.Run("Should create ConfigMaps and Secret", func(t *testing.T) { | |||
| g := gomega.NewGomegaWithT(t) | |||
There was a problem hiding this comment.
Gomega is more flexible and expressive than testify. We also use Gomega in integration tests so I'd like to stick to Gomega for new code.
Codecov Report
@@ Coverage Diff @@
## main #530 +/- ##
==========================================
+ Coverage 70.70% 70.83% +0.12%
==========================================
Files 63 63
Lines 4028 4042 +14
==========================================
+ Hits 2848 2863 +15
+ Misses 871 866 -5
- Partials 309 313 +4
Continue to review full report at Codecov.
|
deven0t
approved these changes
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #524
Signed-off-by: Daniel Pacak pacak.daniel@gmail.com