refactor: Use embed package to define ConfigAuditReports CRD #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #531 +/- ##
==========================================
- Coverage 70.70% 70.60% -0.11%
==========================================
Files 63 63
Lines 4028 4031 +3
==========================================
- Hits 2848 2846 -2
- Misses 871 874 +3
- Partials 309 311 +2
Continue to review full report at Codecov.
|
danielpacak
commented
Apr 23, 2021
| @@ -15,76 +11,9 @@ const ( | |||
| ConfigAuditReportListKind = "ConfigAuditReportList" | |||
| ) | |||
|
|
|||
| var ( | |||
| // TODO Once we migrate to Go 1.16 we can use the embed package to load the CRD from ./deploy/crd/configauditreports.crd.yaml | |||
| ConfigAuditReportCRD = apiextensionsv1.CustomResourceDefinition{ | |||
There was a problem hiding this comment.
This Go struct literal is duplicate of deploy/crd/configauditreports.crd.yaml
deven0t
approved these changes
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Pacak pacak.daniel@gmail.com