Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use embed package to define CISKubeBenchReports and KubeHunterReports CRDs #532

Merged
merged 1 commit into from Apr 26, 2021

Conversation

danielpacak
Copy link
Contributor

Signed-off-by: Daniel Pacak pacak.daniel@gmail.com

…terReports CRDs

Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
@danielpacak danielpacak added this to the Release v0.10.2 milestone Apr 23, 2021
@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #532 (cf69a7d) into main (3d7ad49) will decrease coverage by 0.12%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #532      +/-   ##
==========================================
- Coverage   70.82%   70.69%   -0.13%     
==========================================
  Files          63       63              
  Lines        4045     4051       +6     
==========================================
- Hits         2865     2864       -1     
- Misses        866      871       +5     
- Partials      314      316       +2     
Impacted Files Coverage Δ
pkg/kube/cr_manager.go 49.04% <50.00%> (-0.63%) ⬇️
pkg/operator/controller/ciskubebenchreport.go 61.11% <0.00%> (-5.00%) ⬇️
pkg/operator/controller/vulnerabilityreport.go 68.31% <0.00%> (+1.23%) ⬆️
pkg/operator/controller/configauditreport.go 67.63% <0.00%> (+1.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d7ad49...cf69a7d. Read the comment docs.

Copy link
Member

@simar7 simar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice always good to see code getting removed 🙂

@danielpacak danielpacak merged commit 29992e4 into main Apr 26, 2021
@danielpacak danielpacak deleted the embed_crds branch April 26, 2021 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants