Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use builder for config audit scan jobs #533

Merged
merged 1 commit into from Apr 26, 2021

Conversation

danielpacak
Copy link
Contributor

Signed-off-by: Daniel Pacak pacak.daniel@gmail.com

@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #533 (95dd3f7) into main (29992e4) will decrease coverage by 0.07%.
The diff coverage is 90.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #533      +/-   ##
==========================================
- Coverage   70.79%   70.72%   -0.08%     
==========================================
  Files          63       63              
  Lines        4051     4048       -3     
==========================================
- Hits         2868     2863       -5     
- Misses        868      869       +1     
- Partials      315      316       +1     
Impacted Files Coverage Δ
pkg/starboard/plugin.go 80.95% <ø> (ø)
pkg/configauditreport/scanner.go 73.21% <75.00%> (-8.98%) ⬇️
pkg/configauditreport/builder.go 84.61% <88.46%> (+4.12%) ⬆️
itest/matcher/matcher.go 82.27% <100.00%> (ø)
pkg/operator/controller/ciskubebenchreport.go 63.33% <100.00%> (ø)
pkg/operator/controller/configauditreport.go 63.90% <100.00%> (-3.74%) ⬇️
pkg/operator/controller/limit_checker.go 71.42% <100.00%> (ø)
pkg/operator/controller/vulnerabilityreport.go 69.13% <100.00%> (+0.82%) ⬆️
pkg/operator/predicate/predicate.go 92.59% <100.00%> (ø)
pkg/plugin/factory.go 77.14% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29992e4...95dd3f7. Read the comment docs.

@danielpacak danielpacak force-pushed the refactor_configaudit_scan_job_builder branch from f7fffc0 to 31c9de4 Compare April 23, 2021 22:49
Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
@danielpacak danielpacak force-pushed the refactor_configaudit_scan_job_builder branch from 31c9de4 to 95dd3f7 Compare April 26, 2021 11:10
@danielpacak danielpacak merged commit 858ba0d into main Apr 26, 2021
@danielpacak danielpacak deleted the refactor_configaudit_scan_job_builder branch April 26, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant