Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(trivy): Configure insecure image registries #548

Merged
merged 1 commit into from May 9, 2021

Conversation

xyoxo
Copy link
Contributor

@xyoxo xyoxo commented May 2, 2021

Resolves: #545

@codecov
Copy link

codecov bot commented May 2, 2021

Codecov Report

Merging #548 (bf50cfa) into main (85af65f) will decrease coverage by 0.00%.
The diff coverage is 70.00%.

❗ Current head bf50cfa differs from pull request most recent head ca9dd2b. Consider uploading reports for the commit ca9dd2b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #548      +/-   ##
==========================================
- Coverage   70.62%   70.61%   -0.01%     
==========================================
  Files          63       63              
  Lines        4054     4074      +20     
==========================================
+ Hits         2863     2877      +14     
- Misses        869      876       +7     
+ Partials      322      321       -1     
Impacted Files Coverage Δ
pkg/plugin/trivy/plugin.go 79.15% <62.50%> (-0.74%) ⬇️
pkg/starboard/config.go 75.43% <100.00%> (+0.58%) ⬆️
pkg/operator/controller/configauditreport.go 61.53% <0.00%> (-4.33%) ⬇️
pkg/operator/controller/vulnerabilityreport.go 68.31% <0.00%> (+1.64%) ⬆️
pkg/operator/controller/ciskubebenchreport.go 63.88% <0.00%> (+2.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85af65f...ca9dd2b. Read the comment docs.

@danielpacak danielpacak self-requested a review May 4, 2021 13:14
Copy link
Contributor

@danielpacak danielpacak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start @xyoxo See my comments before we can merge this PR

pkg/starboard/config.go Outdated Show resolved Hide resolved
pkg/plugin/trivy/plugin.go Outdated Show resolved Hide resolved
pkg/plugin/trivy/plugin.go Outdated Show resolved Hide resolved
@danielpacak danielpacak added this to the Release v0.10.2 milestone May 9, 2021
@danielpacak danielpacak merged commit 472fd92 into aquasecurity:main May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(trivy): Configure insecure image registries
2 participants