feat(Conftest): Upgrade Conftest from v0.23.0 to v0.25.0 and use --no-fail flag #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielpacak
commented
May 7, 2021
| @@ -152,7 +152,7 @@ func (p *plugin) GetScanJobSpec(ctx starboard.PluginContext, obj client.Object) | |||
| // TODO Follow up with Conftest maintainers to allow returning 0 exit code in case of failures | |||
| Args: []string{ | |||
| "-c", | |||
| "conftest test --output json --all-namespaces --policy /project/policy /project/workload.yaml || true", | |||
| "conftest test --no-fail --output json --all-namespaces --policy /project/policy /project/workload.yaml", | |||
There was a problem hiding this comment.
Finally, we ca fix the hack used for the POC
Codecov Report
@@ Coverage Diff @@
## main #557 +/- ##
=======================================
Coverage 70.81% 70.81%
=======================================
Files 63 63
Lines 4054 4054
=======================================
Hits 2871 2871
+ Misses 867 863 -4
- Partials 316 320 +4
Continue to review full report at Codecov.
|
…-fail flag Resolves: #512 Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
itaysk
approved these changes
May 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #512
Signed-off-by: Daniel Pacak pacak.daniel@gmail.com