chore: test the helm chart in the PR

[krol3]

• Run the testing helm chart in the PR (only 'deploy/helm/**')
• Separate the release chart in another job.

[codecov]

Codecov Report

Merging #829 (53b7173) into main (df182b7) will increase coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #829      +/-   ##
==========================================
+ Coverage   65.61%   65.72%   +0.10%     
==========================================
  Files          58       58              
  Lines        6460     6460              
==========================================
+ Hits         4239     4246       +7     
+ Misses       1791     1789       -2     
+ Partials      430      425       -5     

Impacted Files	Coverage Δ
pkg/operator/controller/configauditreport.go	64.41% <0.00%> (-0.30%)	⬇️
pkg/operator/controller/ciskubebenchreport.go	59.38% <0.00%> (+1.31%)	⬆️
pkg/operator/controller/vulnerabilityreport.go	64.68% <0.00%> (+1.74%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df182b7...53b7173. Read the comment docs.

[krol3]

@danielpacak please validate the idea of test the manifest of the helm in the PR, if make sense.

[danielpacak]

Thank you for working on this @krol3 ! I think it's great idea to test the Helm chart as part of our build pipeline.

We have already grouped all checks related to pull requests in a single file called .github/worflow/build.yaml so I'd add such job in there and run it after all integration tests passed for few reasons:

• If tests fail we gonna restart build anyway so doing all these Helm checks would be wasteful.
  
• Maybe not in scope of this PR but ... after creating a Helm release it would be very nice to run actual integration tests to see the the operator deployed with Helm really works (not just that Helm release was created).
• We'd like to get rid of the workflow_dispatch event and publish to Helm repository (and MkDocs) when the release workflow is complete.

[krol3]

@danielpacak the "Test Helm Chart" was moved to the build job.

[danielpacak]

Thanks for working on this @krol3 I just slightly updated the workflow to run Helm chart tests only after integration tests passed (as suggested in my previous review) 🍀 🌏 .