Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): publish mkdocs and Helm chart from the specified ref #861

Merged
merged 1 commit into from
Dec 17, 2021
Merged

chore(ci): publish mkdocs and Helm chart from the specified ref #861

merged 1 commit into from
Dec 17, 2021

Conversation

danielpacak
Copy link
Contributor

Signed-off-by: Daniel Pacak pacak.daniel@gmail.com

Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #861 (4d58b0b) into main (7687ef9) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #861      +/-   ##
==========================================
- Coverage   65.74%   65.68%   -0.07%     
==========================================
  Files          58       58              
  Lines        6460     6460              
==========================================
- Hits         4247     4243       -4     
- Misses       1784     1787       +3     
- Partials      429      430       +1     
Impacted Files Coverage Δ
pkg/operator/controller/configauditreport.go 64.70% <0.00%> (-2.65%) ⬇️
pkg/operator/controller/ciskubebenchreport.go 58.95% <0.00%> (+2.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 539d3f7...4d58b0b. Read the comment docs.

@@ -16,15 +20,16 @@ jobs:
runs-on: ubuntu-20.04
steps:
- name: Checkout
uses: actions/checkout@ec3a7ce113134d7a93b817d10a8272cb61118579 # v2.4.0
uses: actions/checkout@v2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielpacak using the SHA commit, is not a good practice anymore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can trust official GitHub Actions to some extent. When I mentioned SHA some time back I was more concerned about GitHub Actions which are not very actively developed or are maintained by individuals, e.g. rajatjindal/krew-release-bot or dmnemec/copy_file_to_another_repo_action

@danielpacak danielpacak merged commit a6f6024 into aquasecurity:main Dec 17, 2021
@danielpacak danielpacak deleted the revisit_mkdos_and_helm_workflows branch December 17, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants