Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in GetLogsByJobAndContainerName error message #869

Merged
merged 1 commit into from
Dec 21, 2021

Conversation

gabegorelick
Copy link
Contributor

controllered -> controller

@CLAassistant
Copy link

CLAassistant commented Dec 20, 2021

CLA assistant check
All committers have signed the CLA.

@danielpacak danielpacak self-requested a review December 21, 2021 08:19
@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #869 (d22630a) into main (7a8a51c) will increase coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #869      +/-   ##
==========================================
+ Coverage   65.82%   65.88%   +0.06%     
==========================================
  Files          58       58              
  Lines        6460     6460              
==========================================
+ Hits         4252     4256       +4     
+ Misses       1780     1777       -3     
+ Partials      428      427       -1     
Impacted Files Coverage Δ
pkg/kube/logs.go 35.84% <0.00%> (ø)
pkg/operator/controller/ciskubebenchreport.go 55.02% <0.00%> (-2.63%) ⬇️
pkg/operator/controller/configauditreport.go 68.52% <0.00%> (+1.17%) ⬆️
pkg/operator/controller/vulnerabilityreport.go 66.78% <0.00%> (+2.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a8a51c...d22630a. Read the comment docs.

Copy link
Contributor

@danielpacak danielpacak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @gabegorelick ! Thanks

@danielpacak danielpacak merged commit b8d8568 into aquasecurity:main Dec 21, 2021
@danielpacak danielpacak added this to the Release v0.14.0 milestone Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants