feat: Vulnerability scan using Trivy fs scan command #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deven0t
force-pushed
the
fs-scan-same-host
branch
from
0241e7f
to
15f5ec7
Compare
Codecov Report
@@ Coverage Diff @@
## main #872 +/- ##
==========================================
- Coverage 65.02% 64.89% -0.13%
==========================================
Files 59 59
Lines 6679 6982 +303
==========================================
+ Hits 4343 4531 +188
- Misses 1886 1997 +111
- Partials 450 454 +4
Continue to review full report at Codecov.
|
deven0t
force-pushed
the
fs-scan-same-host
branch
3 times, most recently
from
6d4b155
to
77d9918
Compare
danielpacak
suggested changes
Jan 7, 2022
There was a problem hiding this comment.
Hey @deven0t It's a good start. See my comments and let me know wdyt?
deven0t
force-pushed
the
fs-scan-same-host
branch
3 times, most recently
from
857e668
to
41107fe
Compare
danielpacak
reviewed
Jan 18, 2022
There was a problem hiding this comment.
👋 @deven0t Overall the changes look good to me! I left a few more comments to consider. Let's catch up and discuss before we merge this PR.
``trivy.command: fs`` will change the trivy scan option to pick up vulnerability scans using trivy fs scan command This is the implementation of approach suggested here aquasecurity#830
deven0t
force-pushed
the
fs-scan-same-host
branch
from
41107fe
to
c2c8b13
Compare
danielpacak
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trivy.command: fswill change the trivy scan option to pick up vulnerability scansusing trivy fs scan command
This is the implementation of first approach suggested here #830